Change 'Two images' pattern to wide width #23856
Conversation
enriquesanchez
added
the
[Feature] Patterns
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +419 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Hmm — this doesn't seem ok to me. We shouldn't include something pixelly... If we don't have any larger versions to draw from, maybe we swap with a different image from the Core patterns library for now? (if there are other good options there?) |
@kjellr Thanks, and I think you're right. The other images we already use in the block and patterns library are also not high-res enough for this big of a size. While less noticeable, the pixelation is still there:
I'd be more than glad to donate a couple of images I've taken, but I worry this will lead to a larger discussion about sourcing images:
|
|
Those photos of the mountains are amazing, Enrique! But I too fear this will lead into another long discussion about whether those are the right images. @kjellr what do you think. If we keep the lower rez images, we should keep the block set for the default width. If we want to go wider, we'll need new images. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
I think the wider images are much nicer, but we definitely can't have them be pixelly. I'm sure we have higher-resolution versions of those same images — can we not upload those? |
|
I've requested to update the images for higher-res versions here: https://core.trac.wordpress.org/ticket/50650 |
Change the image URLs to reflect the proposed new location from the Core Trac ticket.
|
Since images cannot be replaced on the CDN reliably (caching is too persistent), the plan proposed on the Core Trac ticket is to use the same image names and just introduce them into a new folder, |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Updates the 'Two images' pattern to be wide width.
Before:
After:
One issue after this update is that the images are not high-res enough for this size, especially the left one. Considering that we are constrained by the images we can source for the Core patterns library in Core, it might be OK to go with this until we come up with a solution re: images.