Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply the reset mixin to the inserter panel #23744

Merged
merged 2 commits into from
Jul 8, 2020
Merged

apply the reset mixin to the inserter panel #23744

merged 2 commits into from
Jul 8, 2020

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jul 7, 2020 •
edited
Loading

closes #23720

Ideally the theme editor styles shouldn't depend on global resets like this but this makes it consistent in the editor regardless.

testing instructions

  • Make sure the patterns are centered properly on the inserter panel on 2019

@youknowriad youknowriad self-assigned this Jul 7, 2020
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Jul 7, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2020 •
edited
Loading

Size Change: +475 B (0%)

Total Size: 1.14 MB

Filename Size Change
build/api-fetch/index.js 3.39 kB -1 B
build/block-directory/index.js 7.67 kB +1 B
build/block-editor/index.js 115 kB -358 B (0%)
build/block-editor/style-rtl.css 10.8 kB +1 B
build/block-editor/style.css 10.8 kB +1 B
build/block-library/editor-rtl.css 7.54 kB -31 B (0%)
build/block-library/editor.css 7.54 kB -33 B (0%)
build/block-library/index.js 130 kB -49 B (0%)
build/block-library/style-rtl.css 7.75 kB -29 B (0%)
build/block-library/style.css 7.76 kB -25 B (0%)
build/blocks/index.js 48.2 kB -1 B
build/components/index.js 198 kB -37 B (0%)
build/compose/index.js 9.56 kB -1 B
build/core-data/index.js 11.4 kB +1 B
build/edit-navigation/index.js 10.8 kB +862 B (7%) 🔍
build/edit-navigation/style-rtl.css 1.08 kB +59 B (5%) 🔍
build/edit-navigation/style.css 1.08 kB +59 B (5%) 🔍
build/edit-post/index.js 304 kB -19 B (0%)
build/edit-post/style-rtl.css 5.59 kB +17 B (0%)
build/edit-post/style.css 5.58 kB +17 B (0%)
build/edit-site/index.js 16.6 kB +12 B (0%)
build/editor/index.js 45 kB +31 B (0%)
build/element/index.js 4.65 kB -1 B
build/list-reusable-blocks/index.js 3.12 kB +4 B (0%)
build/media-utils/index.js 5.32 kB +1 B
build/nux/index.js 3.4 kB -2 B (0%)
build/plugins/index.js 2.56 kB +2 B (0%)
build/rich-text/index.js 13.9 kB -9 B (0%)
build/server-side-render/index.js 2.71 kB +1 B
build/token-list/index.js 1.28 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.46 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/index.js 9.35 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.4 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@youknowriad youknowriad force-pushed the fix/patterns-centering-issue branch from 2ea5f7e to 0e7940e Compare July 7, 2020 12:59
@enriquesanchez
Copy link
Contributor

This fixes the issue in Twenty Nineteen:

2019

But I'm still seeing it in 2017:

2017a

2017b

...and 2015:

2015a

2015b

Resetting the margin to 0 in .block-editor-block-preview__container.editor-styles-wrapper seems to fix it.

@youknowriad
Copy link
Contributor Author

Yes, this was raised I believe already. Having margins on the editor styles do break more than the patterns preview.

@enriquesanchez
Copy link
Contributor

Having margins on the editor styles do break more than the patterns preview.

@youknowriad Is this something we can fix at least for pattern previews?

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 8, 2020
@youknowriad youknowriad requested a review from ellatrix as a code owner July 8, 2020 08:41
@youknowriad
Copy link
Contributor Author

As you can see on your screenshots, the "gray" area around the canvas is a symptom of that issue. This should be definitely fixed in the editor styles (track ticket), that said I forced the margins for the preview to fix it for the patterns.

@youknowriad
Copy link
Contributor Author

Merging this to include in the release.

@youknowriad youknowriad merged commit 6552c31 into master Jul 8, 2020
@youknowriad youknowriad deleted the fix/patterns-centering-issue branch July 8, 2020 10:29
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 8, 2020
youknowriad added a commit that referenced this pull request Jul 8, 2020
@youknowriad
Fix block patterns preview margins and paddings. (#23744)
878f091
@youknowriad youknowriad mentioned this pull request Jul 8, 2020
Merged
youknowriad added a commit that referenced this pull request Jul 13, 2020
@youknowriad
Fix block patterns preview margins and paddings. (#23744)
d2b0cff
@youknowriad youknowriad mentioned this pull request Jul 13, 2020
Merged
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enriquesanchez enriquesanchez Awaiting requested review from enriquesanchez

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.6
Development

Successfully merging this pull request may close these issues.

Block Patterns: previews overflow the container in some themes
2 participants
@youknowriad @enriquesanchez