Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool Selector: Render the edit icon as an Icon component #23743

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Tool Selector: Render the edit icon as an Icon component #23743

merged 1 commit into from
Jul 7, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Jul 7, 2020

Description

Currently, the edit icon in the Tool Selector is rendered as a simple SVG element without size attributes, which makes it show up at an incorrect size.
This PR renders the icon through the Icon component, which automatically takes care of the size.

How has this been tested?

Tested with wp-env on both Firefox 78 and Chrome 83 on macOS 10.15.5.

Screenshots

Before After
Screenshot 2020-07-07 at 12 25 08 Screenshot 2020-07-07 at 12 24 45

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Copons Copons added the [Type] Bug An existing feature does not function as intended label Jul 7, 2020
@Copons Copons self-assigned this Jul 7, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2020 •
edited
Loading

Size Change: +12 B (0%)

Total Size: 1.14 MB

Filename Size Change
build/block-editor/index.js 115 kB +12 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.67 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.57 kB 0 B
build/block-library/editor.css 7.57 kB 0 B
build/block-library/index.js 130 kB 0 B
build/block-library/style-rtl.css 7.78 kB 0 B
build/block-library/style.css 7.79 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 199 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/compose/index.js 9.56 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.46 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 9.96 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.57 kB 0 B
build/edit-post/style.css 5.57 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/index.js 9.35 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 45 kB 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.4 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

youknowriad
youknowriad approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@youknowriad youknowriad added this to the Gutenberg 8.5 milestone Jul 7, 2020
@youknowriad
Copy link
Contributor

A rebase should fix the failures here.

@Copons Copons force-pushed the fix/edit-tool-icon-size branch from 312fffa to 86ba539 Compare July 7, 2020 13:36
@Copons Copons merged commit ffd946f into master Jul 7, 2020
@Copons Copons deleted the fix/edit-tool-icon-size branch July 7, 2020 14:57
@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 8, 2020
youknowriad pushed a commit that referenced this pull request Jul 8, 2020
@Copons @youknowriad
Tool Selector: Render the edit icon as an Icon component (#23743)
b80da14
@youknowriad youknowriad mentioned this pull request Jul 8, 2020
Merged
youknowriad pushed a commit that referenced this pull request Jul 13, 2020
@Copons @youknowriad
Tool Selector: Render the edit icon as an Icon component (#23743)
1279221
@youknowriad youknowriad mentioned this pull request Jul 13, 2020
Merged
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ockham ockham Awaiting requested review from ockham

@vindl vindl Awaiting requested review from vindl

@noahtallen noahtallen Awaiting requested review from noahtallen

@Addison-Stavlo Addison-Stavlo Awaiting requested review from Addison-Stavlo

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@Copons Copons

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Copons @youknowriad