Block Library: Standardize post block placeholders. #23690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ItsJonQ
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
@epiqueras Looks good to me! Thank you for your work (as always) ❤️
Non-blocking question! Do these values need to be wrapped with the i18n __() function? 🤔
|
I'm not sure. Does it make sense to translate the block name? @mtias @youknowriad |
|
@epiqueras Yes, we should make all strings translatable. The block titles are already translated in the |
|
Definitely yes on the translations. |
|
Already merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some post blocks were not rendering anything when missing a post context. The placeholder content was also inconsistent. This PR fixes both points.
How has this been tested?
It was verified that post blocks used outside a post context, E.g., in the site editor's front template, render their name and all their relevant toolbar and inspector controls.
Checklist: