Add error boundary to experimental navigation screen #23679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
talldan,
draganescu and
noisysocks
and removed request for
talldan and
draganescu
adamziel
added
[Feature] List View
adamziel
removed
the
[Feature] List View
|
Size Change: +8.41 kB (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Need to check that onError isn't undefined, but otherwise this is good. Approving in advance so that I don't hold you up.
Agree that a component which edit-post, edit-navigation and edit-widgets shares would be good. It could contain both Attempt recovery and Copy error.
| } | ||
|
|
||
| reboot() { | ||
| this.props.onError(); |
There was a problem hiding this comment.
undefined.
Suggested change
| this.props.onError(); | |
| if ( this.props.onError ) { | |
| this.props.onError(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #23417 by adding an error boundary to inform the user about any problems (instead of displaying the blank page).
There is a similar component in the editor package, but it's editor-specific enough to justify creating a "private" component for the purposes of edit-navigation package. Bringing a configurable ErrorBoundary component to
@wordpress/componentsis definitely worth discussing as there are more places that could benefit from it (e.g. the widgets screen).How has this been tested?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: