Avoid ordering block types per frecency inside block categories #23643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
Size Change: -5 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I still think there's a place for this functionality, but it'd have to be weighted differently for it to be effective. If I insert videos all the time and very seldomly use galleries, it stands to reason that video could move up the order, but it should happen in a slower less random way. The same applies for a 3rd party gallery becoming more used than core's gallery. It's something we'll need to continue thinking through. |
ellatrix
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23074
closes #22406
The frecency should only be used on the "Most Used" category while the other categories should respect the registration order to avoid block type jumps when we insert items.
While this is not exactly what #23074 suggests, I think it's a sufficient resolution since the "most used" blocks section can be disabled.