Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel previous running workflows when a new commit is made #23587

Merged
merged 7 commits into from
Jul 7, 2020

Conversation

ceyhun
Copy link
Member

@ceyhun ceyhun commented Jun 30, 2020

Description

Added a new GitHub action workflow named Cancel using styfle/cancel-workflow-action to cancel all running workflows on a branch when a new commit is made.

How has this been tested?

See the commits Test 1 and Test 2 cancelling previous runs. Force-pushes also work.

@github-actions
Copy link

github-actions bot commented Jun 30, 2020

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.42 kB 0 B
build/block-directory/style-rtl.css 941 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 109 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.44 kB 0 B
build/block-library/editor.css 7.44 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 8.04 kB 0 B
build/block-library/style.css 8.05 kB 0 B
build/block-library/theme-rtl.css 730 B 0 B
build/block-library/theme.css 732 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 15.9 kB 0 B
build/components/style.css 15.9 kB 0 B
build/compose/index.js 9.65 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.19 kB 0 B
build/edit-navigation/index.js 9.88 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.51 kB 0 B
build/edit-post/style.css 5.51 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3 kB 0 B
build/edit-site/style.css 3 kB 0 B
build/edit-widgets/index.js 9.32 kB 0 B
build/edit-widgets/style-rtl.css 2.42 kB 0 B
build/edit-widgets/style.css 2.42 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 44.9 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.86 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 450 B 0 B
build/list-reusable-blocks/style.css 451 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ceyhun ceyhun force-pushed the cancel-macos-workflows branch 4 times, most recently from 61cc4e8 to 673f0f9 Compare July 1, 2020 12:49
@ceyhun ceyhun force-pushed the cancel-macos-workflows branch from 673f0f9 to 779cd00 Compare July 1, 2020 13:12
@ceyhun ceyhun added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jul 1, 2020
@ceyhun ceyhun marked this pull request as ready for review July 1, 2020 13:21
@ceyhun ceyhun requested a review from gziolo July 1, 2020 13:21
@gziolo
Copy link
Member

gziolo commented Jul 1, 2020

I know little about GitHub actions. I can approve just to validate it in action. @youknowriad what do you think?

@@ -0,0 +1,15 @@
name: Cancel
on: [push]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push only runs if you have the rights on the repository, not if you make a PR from a fork. How can we ensure to run this on fork PRs updates too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to trigger only on pull_request events, which should run on forked repos as well: https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories

Most of the current workflows are already triggered on pull_request and some also on push to master. This way it won't cancel those triggered via push to master and maybe that's better.

@youknowriad
Copy link
Contributor

Github should probably do this by default but this is cool in the meantime.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

@ceyhun ceyhun merged commit 8c234b7 into master Jul 7, 2020
@ceyhun ceyhun deleted the cancel-macos-workflows branch July 7, 2020 09:32
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 7, 2020
@youknowriad
Copy link
Contributor

This job is cool but it triggers too many email notifications for me so i end up missing the good notifications. Any way we can disable notifications just for this job?

@ceyhun
Copy link
Member Author

ceyhun commented Jul 8, 2020

What kind of notifications? Do you mean ones with titles starting with [WordPress/gutenberg] Run cancelled... for the cancelled jobs?

@youknowriad
Copy link
Contributor

yes, these notifications. I can filter in my own client but I'm pretty sure it's an annoyance for most folks.
i guess we might not be able to do anything about it because it's triggered by the test jobs themselves.

@ceyhun
Copy link
Member Author

ceyhun commented Jul 13, 2020

i guess we might not be able to do anything about it because it's triggered by the test jobs themselves.

Yeah I think that's the case, maybe we can send feedback about it using this form: https://support.github.com/contact/feedback?contact%5Bcategory%5D=actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants