Add pullquote tranformations #23562
Merged
Add pullquote tranformations #23562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Block Transforms
|
Size Change: +261 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/pullquote-tranformations
branch
from
52eacc3 to
a0f8f67
Compare
mcsf
reviewed
Jul 2, 2020
Comment on lines
+17
to
+20
| attributes.map( ( { content } ) => | ||
| create( { html: content } ) | ||
| ), | ||
| '\u2028' |
There was a problem hiding this comment.
I don't feel confident that this is the optimal way to do it, so I'll defer to @ellatrix for review. This includes the logic further down in the 'to' transforms.
There was a problem hiding this comment.
This was actually the same as Quote. Didn't really dig into that. Seemed to me a Business Logic decision that has been made, to transform the first part only..
There was a problem hiding this comment.
You're right. That's good enough for me!
mcsf
approved these changes
Jul 3, 2020
|
Thanks @mcsf ! I totally agree that these two are so similar that could be handled together in the future. |
ntsekouras
force-pushed
the
add/pullquote-tranformations
branch
from
9452e48 to
a83ec90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #14159
Now, the
Pullquotetransformations are handled in an inconsistent way compared to aQuoteblock, that is quite similar.For example you can achieve transformation from a
ParagraphtoPullquote, by first transforming theParagraphto aQuoteand then theQuoteto aPullquote.This PR will allow
Pullquoteblock to be transformed from and to all the available blocks that are allowed forQuoteblock.How has this been tested?
Screenshots
Types of changes
Checklist: