[RN-MOBILE] fix line height crash #23507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marecar3
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
5 tasks
hypest
approved these changes
Jun 26, 2020
|
Rerunning jobs as the mobile E2E job suffered from the known |
Thanks for the approval! |
|
The CI job failed again but, since we know for sure that it's not an issue with this PR and there's already another PR to address the issue, I'll go ahead and merge. |
SergioEstevao
pushed a commit
that referenced
this pull request
Jun 26, 2020
* Fix line-height crash * format fix * Add block example with lineHeight attribute
SergioEstevao
added a commit
that referenced
this pull request
Jul 8, 2020
* Run pod install in react-native-editor/ios/ * [RN-MOBILE] fix line height crash (#23507) * Fix line-height crash * format fix * Add block example with lineHeight attribute * [RNMobile] Correct Buttons block width (#23616) * Fix quote left border color in dark mode. (#23692) * Update react-native-editor package and release notes. * Fix translations for media options * Load block-library lazily after translations occur to fix names of blocks in inserter. * lint fixes * Merge master branch to merge_rnmobile_1.31.1_to_master Co-authored-by: Paul Von Schrottky <[email protected]> Co-authored-by: Marko Savic <[email protected]> Co-authored-by: Luke Walczak <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]> Co-authored-by: Cameron Voell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/WordPress-Android#12211
Description
Current Gutenberg implementation is supporting line-height without unit e.g. 'line-height':1.5
and library which we are using to convert css to react-native requires unit to be included with dimension and that scenario is leading to crash of the Aztec wrapper on Android.
However, we didn't choose to fix (patch) the library as native AztevView doesn't support lineHeight at this moment so focus on this fix was to remove lineHeight from style.
How has this been tested?
Run the Demo app and app shouldn't crash
Checklist: