Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Media-Text: Removed the block type limitation when adding blocks #23456

Merged
merged 1 commit into from
Jul 1, 2020
Merged

[Mobile] Media-Text: Removed the block type limitation when adding blocks #23456

merged 1 commit into from
Jul 1, 2020

Conversation

antonis
Copy link
Member

@antonis antonis commented Jun 25, 2020 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#2386

Related PRs:

gutenberg-mobile wordpress-mobile/gutenberg-mobile#2441

Description

This fix Removes the block type limitation when adding blocks in the Media-Text

How has this been tested?

  • Add a Media-Text block
  • Press the add button
  • See that all blocks can be added

Screenshots

Add menu Rendering
Simulator Screen Shot - iPhone 11 - 2020-06-25 at 13 40 57 Simulator Screen Shot - iPhone 11 - 2020-06-25 at 13 42 05
Landscape
Simulator Screen Shot - iPhone 11 - 2020-06-25 at 13 42 45

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@chipsnyder chipsnyder self-requested a review June 25, 2020 13:24
@chipsnyder chipsnyder self-assigned this Jun 25, 2020
@chipsnyder chipsnyder added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 25, 2020
@chipsnyder chipsnyder added this to the Future milestone Jun 25, 2020
@antonis antonis mentioned this pull request Jun 29, 2020
Closed
2 tasks
@antonis antonis marked this pull request as ready for review June 29, 2020 14:02
chipsnyder
chipsnyder approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @antonis

@antonis antonis changed the title Media-Text: Removed the block type limitation when adding blocks [Mobile] Media-Text: Removed the block type limitation when adding blocks Jul 1, 2020
@chipsnyder
Copy link
Contributor

Closing and reopening to try and trigger updated status checks.

@chipsnyder chipsnyder closed this Jul 1, 2020
@chipsnyder
Copy link
Contributor

Reopening to try and trigger updated status checks.

@chipsnyder chipsnyder reopened this Jul 1, 2020
@chipsnyder chipsnyder merged commit f515903 into WordPress:master Jul 1, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 1, 2020
@antonis antonis mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

Assignees

@chipsnyder chipsnyder

Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @chipsnyder