Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons block: remove margin from last button #23319

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Buttons block: remove margin from last button #23319

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be1d207
Remove margin from last button if buttons are centered
Aljullu Jun 19, 2020
aed2ea7
Remove last button margin for left and right aligned buttons too
Aljullu Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove margin from last button if buttons are centered
  • Loading branch information
@Aljullu
Aljullu committed Jun 19, 2020
commit be1d20793e17456c19d2678985fdfc7c597ac27a
4 changes: 4 additions & 0 deletions packages/block-library/src/buttons/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@

.wp-block-buttons.aligncenter {
text-align: center;

.wp-block-button:last-child {
margin-right: 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Do you think we should remove this margin in all cases, not just the aligned centered buttons? (And the left margin in case of the aligned right ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Done in the last commit: aed2ea7.

Before After
imatge imatge

}