Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Social icons #23017

Merged
merged 39 commits into from
Jul 9, 2020
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
01400dd
Initial work on social links
lukewalczak Jun 2, 2020
25f4d71
Style social links and their infra
lukewalczak Jun 5, 2020
835f7f2
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 5, 2020
7f35aac
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 8, 2020
b40ad02
Correct action sheet labels and add header
lukewalczak Jun 8, 2020
dafa685
Merge branch 'rnmobile/correct-action-sheet-labels' into rnmobile/soc…
lukewalczak Jun 8, 2020
5deb622
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 8, 2020
9f1ad97
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 15, 2020
ae263c4
Main social icons refactor
lukewalczak Jun 15, 2020
216f3cc
Refactor animation in social links, blur post title when unselected
lukewalczak Jun 16, 2020
85eb3ae
Wrap Svg in forwardRef to pass the ref to func component
lukewalczak Jun 16, 2020
76cf8d6
Add placeholder for inactive unselected icons
lukewalczak Jun 18, 2020
a0edba7
Correct undo in social links
lukewalczak Jun 18, 2020
4eae11c
Create link settings component
lukewalczak Jun 19, 2020
015ab5a
Merge branch 'rnmobile/link-settings' into rnmobile/social_links
lukewalczak Jun 19, 2020
08aeedc
Use LinkSettings
lukewalczak Jun 19, 2020
631daee
Display social icon name on mobile platform
lukewalczak Jun 22, 2020
0217143
Use usePrevious hook
lukewalczak Jun 23, 2020
036c6c4
Add props description, refactor some props
lukewalczak Jun 23, 2020
f56525e
Merge branch 'rnmobile/link-settings' into rnmobile/social_links
lukewalczak Jun 24, 2020
342228f
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 24, 2020
90f6ec1
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 24, 2020
ff15202
Correct e2e test
lukewalczak Jun 24, 2020
c74f14c
Code clean up
lukewalczak Jun 25, 2020
40333ea
Code refactor
lukewalczak Jun 25, 2020
3921817
Revert block picker changes
lukewalczak Jun 25, 2020
2ae940b
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 30, 2020
15949b9
Merge branch 'master' into rnmobile/social_links
lukewalczak Jun 30, 2020
8f274a8
Add a11y to social links
lukewalczak Jun 30, 2020
030ce31
Use button size variable
lukewalczak Jun 30, 2020
c10c55a
Refactor social icons
lukewalczak Jul 3, 2020
7a9575d
Revert post title changes
lukewalczak Jul 3, 2020
9fbb610
Merge branch 'master' into rnmobile/social_links
lukewalczak Jul 3, 2020
c58e64e
Code refactor, add svg wrapper
lukewalczak Jul 6, 2020
c3fc255
Merge branch 'master' into rnmobile/social_links
lukewalczak Jul 7, 2020
509c5cb
Remove initialAttributes
lukewalczak Jul 7, 2020
763459e
Merge branch 'master' into rnmobile/social_links
lukewalczak Jul 7, 2020
7c21866
Add check for block name
lukewalczak Jul 8, 2020
643b9e5
Merge branch 'master' into rnmobile/social_links
lukewalczak Jul 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a11y to social links
  • Loading branch information
lukewalczak committed Jun 30, 2020
commit 8f274a8e1b6582563a62d15174e56191f220e682
23 changes: 22 additions & 1 deletion packages/block-library/src/social-link/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ const SocialLinkEdit = ( {
}
}

const accessibilityHint = url
? sprintf(
// translators: %s: social link name e.g: "Instagram".
__( '%s has URL set' ),
socialLinkName
)
: sprintf(
// translators: %s: social link name e.g: "Instagram".
__( '%s has no URL set' ),
socialLinkName
);

return (
<View>
{ isSelected && (
Expand Down Expand Up @@ -153,7 +165,16 @@ const SocialLinkEdit = ( {
options={ options }
withBottomSheet={ true }
/>
<TouchableWithoutFeedback onPress={ onIconPress }>
<TouchableWithoutFeedback
onPress={ onIconPress }
accessibilityRole={ 'button' }
accessibilityLabel={ sprintf(
// translators: %s: social link name e.g: "Instagram".
__( '%s social icon' ),
socialLinkName
) }
accessibilityHint={ accessibilityHint }
>
<Animated.View
style={ [ styles.iconContainer, { backgroundColor } ] }
>
Expand Down