-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block areas tabbed sidebar to the widgets screen #22467
Add block areas tabbed sidebar to the widgets screen #22467
Conversation
Size Change: +1.99 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Lookin' good! So glad to see this added. I've got a few changes. 1. Text changesCurrently, the Block Area description is this:
Can we update it to:
2. Block Area selectionThe Block Area is an "area" and not necessarily a block, correct? But when I select the block area from the sidebar, it shows a block toolbar and switches to the "Block" tab in the sidebar which describes it as a "Widget Area." This feels wrong. The Block Area tab should mimic the Document tab from the editor. It's not quite a block.
3. Toolbar overlapThis may be solved with number 2 above. 4. Selecting a blockWhen I select a block, it should switch the tab in the sidebar to the "Block" tab just like it does in the Editor. Currently, it does not. 5. Change the icon for Block AreaRight now the calendar icon is being used here. We should swap this out with the template part icon being used elsewhere. |
Hi @mapk thank you for the review 👍 Your suggestions were applied! This is ready for another look. |
Thanks for the speedy updates, @jorgefilipecosta!
Changes still needed: 1. Block Area still has a toolbarI think we should drop the toolbar for the Block Areas. Right now it offers a "Copy" option which is confusing. What does this copy; the contents or the actual Block Area? If it copies the Block Area, why? 2. Remove some textI still see this text in the Block Area description:
Can you remove that? |
82752d0
to
68f674c
Compare
Hi @mapk,
The toolbar was already disabled for the widget area block (the container). Maybe it was a caching issue? Let me know if the toolbar keeps appearing in your tests.
The text was removed. |
b664cb6
to
e2cfcd6
Compare
A couple more changes... 1. The toggling effect of the sidebar block area links.When clicking the block area in the sidebar, the result should be that the block area in the page highlights. I noticed that it toggles the highlight, and then can't toggle it back on again. 2. IconAs mentioned above, can we update the icon in the screenshot below to the lego-looking icon? |
5967e60
to
964a3ee
Compare
964a3ee
to
0a298ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took it for another spin and it worked well. 👍
Description
This PR adds the block areas tabbed sidebar to the widgets screen.
This change tries to follow the design suggested by @mapk and makes the screen more similar to edit-post.
How has this been tested?
I enabled the "Twenty Seventeen" theme.
I loaded the widgets screen.
I verified the block areas sidebar was available and I was able to select block areas by pressing on its list of block areas.
I verified when I selected a block the sidebar tab changed to block.
I verified when I unselected a block the sidebar tab changed to block areas.