Fix: Button border radius 0 does not appear, and undefined border appears as 0 #22393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
Soean,
talldan and
youknowriad
as code owners
youknowriad
reviewed
May 15, 2020
| @@ -43,7 +43,7 @@ $blocks-button__height: 56px; | |||
| // the first selector is required for old buttons markup | |||
|
|
|||
| .wp-block-button.no-border-radius, | |||
| .wp-block-button__link.wp-block-button.no-border-radius { | |||
| .wp-block-button .wp-block-button__link.no-border-radius { | |||
There was a problem hiding this comment.
Can we remove .wp-block-button here?
There was a problem hiding this comment.
Suggestion applied :)
There was a problem hiding this comment.
Suggestion applied :)
|
@ItsJonQ this seems a bit related to the "reset" behaviors we were discussing? |
|
Size Change: +275 kB (24%) 🚨 Total Size: 1.11 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/button-border-radius
branch
from
32d8d10 to
dc4607c
Compare
youknowriad
approved these changes
May 19, 2020
|
@jorgefilipecosta Ah! Thanks for catching this! I spotted a bug in the guard for the Before: if ( ! isFinite( value ) ) {
return null;
}After: if ( typeof value !== 'number' ) {
return null;
}This should handle Thank you! 🙏 |
|
Thank you for the enhancement @ItsJonQ. It worked great on my tests 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22367
This PR fixes a wrong CSS rule that made the border 0 radius in button not appear as expected.
It also fixes a bug, when the border-radius is not set (it is undefined and the theme value set with CSS is being used) we were displaying 0 as the border-radius by default, in that case, we should show the input empty.
How has this been tested?
I enabled 2019 theme.
I added a button I set the border-radius to 0 and verified it appeared as expected on the editor and on the front end.
I added a button in 2019 (by default the button has some border) I verified the border did not appear as 0.