-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try old hover design #2155
Try old hover design #2155
Conversation
There has been discussion on the heaviness of the blocks. Initially this led us to having only the left border on hover. We added a full outline so as to better portray that a paragraph is a block. However multi selection across blocks works well. If we can get it to work as well with keyboard shortcuts (and show list and quote options in a toolbar), aside from this addressing #539, it seems like there's less of a need for the block outlines to look so heavy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change personally. The one instance where it looked a little different to me was when a neighboring block is selected, and I hover over the next... something about the full square outline next to the single line on the left.
The other item, though not related to these changes, is the block settings/delete shortcuts feel a bit "heavier" with this change since there is no line along side of these controls they seem extra bold to me.
Great feedback, Timmy. I agree, that's the biggest weakness of this. However the items on the side in general bug me — I know why they're there and what value they bring, but they contribute to the heaviness of the UI. See also #2156 Another option — what if we show the cog and trash button only when you are hovering the right area? That is:
CC: @afercia Perhaps worth trying before we try moving the cog and trash to the quick toolbar. It feels like there's value in being able to hover and click to remove a block. |
Not sure, discoverability might be a problem. I'd rather keep it simple. |
Closing this branch as other efforts are underway. |
* Update ref: Correct colors usage in Buttons
There has been discussion on the heaviness of the blocks. Initially this led us to having only the left border on hover. We added a full outline so as to better portray that a paragraph is a block.
However multi selection across blocks works well. If we can get it to work as well with keyboard shortcuts (and show list and quote options in a toolbar), aside from this addressing #539, it seems like there's less of a need for the block outlines to look so heavy.
Screenshot: