Bundle the block autocompleter in the block-editor package #21534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Inserter
|
Size Change: -63.9 kB (7%) ✅ Total Size: 839 kB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Apr 13, 2020
| @@ -26,7 +29,13 @@ import { withBlockEditContext } from '../block-edit/context'; | |||
| */ | |||
| export function withFilteredAutocompleters( Autocomplete ) { | |||
| return ( props ) => { | |||
| let { completers = [] } = props; | |||
| let { completers = [], blockName } = props; | |||
There was a problem hiding this comment.
Each time we arrive to this function with undefined completers, completers will be set to a new array reference and useMemo will execute again. Should we have an empty array constant and set the completers default value to it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20619
This PR bundles the block autocompleter by default in all block editor instances. This makes the slash inserter work on the widget screen, edit site screen and the playground.
There's still another WordPress autocompleter that is not enabled on these pages (user) but this one can't be enabled by default as it's WordPress specific, so we need to find another home for it (today it's inside the editor package).