-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glossary.md #21367
Update glossary.md #21367
Conversation
Remove duplicate sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for the fix.
This needs to be rebased against master, it looks like it was opened against 5.4 tag. |
@mkaz We had this issue on slack, see https://wordpress.slack.com/archives/C02QB2JS7/p1585897669457800 |
Correct, that's where the link took me. I've since reset my fork to upstream/master but I'm happy to submit a new PR and reference this. |
@machouinard Strange, it didn't seem to update here. I guess a PR is opened against where it wants to push too. So I think closing this one and opening new one might be best course of action. |
Created a fresh branch off master, pushed to my repo and opened PR. Guess I don't understand GitHub as well as I'd thought as it attached itself here (I mentioned it in the commit). Let me know if you need me to do anything differently. |
In reference to #21367 Signed-off-by: Mark Chouinard <[email protected]>
Thanks @machouinard for creating the new one and moving the change. I approved and merged #21565, so closing this one out. |
Remove duplicate sentence.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: