-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title as a block #2089
Title as a block #2089
Conversation
Cc @melchoyce. |
Other point: a cover image should be able to act as the title? |
Maybe the title even just becomes a value for listing the document somewhere, much like the except, which may or may not be part of the post/document. |
e5085bf
to
ead59d0
Compare
Wouldn't most themes not be able to support these layouts, since |
Love the idea of having a cover image take the place of a title! |
@aduth Yeah, that's what I meant with
The idea is that |
Should not the content of this block get |
I could almost swear by my left hand yesterday I saw Link option for Title block. Giving me option to edit Link (Slug, or whatever. Only link option, no other toolbar icons.). And now I cannot reproduce it, after refresh no more. Some glitch, bug, cannot be sure now. It is Demo Post, I did now add anything to it. PS: I see now, it is a feature not a glitch. Glitch is that I cannot invoke it in Gutenberg Demo Post. Unless I open it via Posts - Gutenberg menu item. Ok, Beta phase, so not so important now. |
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from 'i18n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note with #2172, these need to be updated to prefix the dependencies with @wordpress/
. You will need to perform a rebase against the latest version of master and apply your changes:
git fetch origin
git rebase origin/master
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from 'i18n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note with #2172, these need to be updated to prefix the dependencies with @wordpress/
. You will need to perform a rebase against the latest version of master and apply your changes:
git fetch origin
git rebase origin/master
@iseulde Do you think we should close this and revisit as part of the Template Editor in the customization focus? |
I don't mind closing for now, but I do think it would be interesting to have a movable title. |
👍 I think this is an interesting idea too, although it runs into some re-world implementation challenges. |
This is more of a proof of concept at the moment. There are still some issues to be solved.
Benefits:
[ Title | H2 | H3 | H4 ]
?Issues:
A middle way could be fixing it at the top (for now), but I like the idea of it being a full block.