-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Social Link: Escape generated class name #20479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
mcsf
approved these changes
Feb 26, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Social
Affects the Social Block - used to display Social Media accounts
[Package] Block library
/packages/block-library
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to update the Social Link block to correctly escape the output of the service in the generated class name.
Note that this is not a security issue. Block comment attribute values are sanitized based on user capabilities at save time. Rather, this change is intended to preserve HTML integrity, since otherwise a user could potentially "break out" of the
class
attribute and mangle the generated markup.Testing Instructions:
Verify there are no regressions in the class name assigned to a Social Icon block.
class
of the WordPress icon element containswp-social-link-wordpress
.