Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LatestPosts] Fixes the excerpt length #20313

Merged
merged 7 commits into from
Mar 2, 2020
Merged

[LatestPosts] Fixes the excerpt length #20313

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c9def7
adds a filter that sets the excerpt length to what was set in the editor
draganescu Feb 19, 2020
c44c516
adds named function as excerpt filter and removes after use
draganescu Feb 24, 2020
6c783e6
adds PHP doc to the new filter callback and global variable
draganescu Feb 25, 2020
e65fcb7
default to using an anonymous function since it appears that it can b…
draganescu Mar 2, 2020
185751f
revert to named function for excerpt length filter
draganescu Mar 2, 2020
d0025ac
proper function names for Guternberg namespace
draganescu Mar 2, 2020
12fc07d
lower default priority for the latest posts excerpt length filter
draganescu Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/block-library/src/latest-posts/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,26 @@
* @package WordPress
*/

/**
* The excerpt length set by the Latest Posts core block
* set at render time and used by the block itself.
*
* @var int
*/
$block_core_latest_posts_excerpt_length = 0;

/**
* Callback for the excerpt_length filter used by
* the Latest Posts block at render time.
*
* @return int Returns the global $block_core_latest_posts_excerpt_length variable
* to allow the excerpt_length filter respect the Latest Block setting.
*/
function block_core_latest_posts_get_excerpt_length() {
global $block_core_latest_posts_excerpt_length;
return $block_core_latest_posts_excerpt_length;
}

draganescu marked this conversation as resolved.
Show resolved Hide resolved
/**
* Renders the `core/latest-posts` block on server.
*
Expand All @@ -13,6 +33,8 @@
* @return string Returns the post content with latest posts added.
*/
function render_block_core_latest_posts( $attributes ) {
global $block_core_latest_posts_excerpt_length;

draganescu marked this conversation as resolved.
Show resolved Hide resolved
$args = array(
'posts_per_page' => $attributes['postsToShow'],
'post_status' => 'publish',
Expand All @@ -21,6 +43,9 @@ function render_block_core_latest_posts( $attributes ) {
'suppress_filters' => false,
);

$block_core_latest_posts_excerpt_length = $attributes['excerptLength'];
add_filter( 'excerpt_length', 'block_core_latest_posts_get_excerpt_length', 20 );

if ( isset( $attributes['categories'] ) ) {
$args['category'] = $attributes['categories'];
}
Expand Down Expand Up @@ -111,6 +136,8 @@ function render_block_core_latest_posts( $attributes ) {
$list_items_markup .= "</li>\n";
}

remove_filter( 'excerpt_length', 'block_core_latest_posts_get_excerpt_length', 20 );

$class = 'wp-block-latest-posts wp-block-latest-posts__list';
if ( isset( $attributes['align'] ) ) {
$class .= ' align' . $attributes['align'];
Expand Down