Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor keyboard shortcuts: fix Toggle Sidebar #19605

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Jan 13, 2020

Description

Fixes primaryShift + , shortcut for toggling the sidebar, a regression from 52000d7 (#19320).

How has this been tested?

Make sure that the shortcut in question can both close and open the sidebar.

@mcsf mcsf added [Type] Bug An existing feature does not function as intended [a11y] Keyboard & Focus labels Jan 13, 2020
@mcsf mcsf requested a review from youknowriad January 13, 2020 21:00
@mcsf mcsf requested a review from talldan as a code owner January 13, 2020 21:00
@mcsf mcsf merged commit 4ecf279 into master Jan 14, 2020
@mcsf mcsf deleted the fix/edit-post-shortcuts-toggle-sidebar branch January 14, 2020 11:32
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants