Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: don't set focus when applying format #19536

Merged
merged 8 commits into from
Jan 13, 2020
Merged

RichText: don't set focus when applying format #19536

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
401d949
Return focus to original element
ellatrix Jan 9, 2020
540051f
Fix list e2e tests
ellatrix Sep 26, 2019
d2905e4
Fix annotation e2e tests
ellatrix Sep 27, 2019
8a1b782
Fix some rich text e2e tests
ellatrix Sep 27, 2019
c087194
Fix tests
ellatrix Sep 27, 2019
da86012
Focus after link
ellatrix Jan 9, 2020
daa575e
Add onFocus
ellatrix Jan 9, 2020
e7eeda3
Corrections
ellatrix Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix annotation e2e tests
  • Loading branch information
@ellatrix
ellatrix committed Jan 9, 2020
commit d2905e4fe3992d587c06615bdc5d184f1584e869
2 changes: 2 additions & 0 deletions packages/e2e-tests/specs/editor/plugins/annotations.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ describe( 'Using Plugins API', () => {
// Click add annotation button.
const addAnnotationButton = ( await page.$x( "//button[contains(text(), 'Add annotation')]" ) )[ 0 ];
await addAnnotationButton.click();
await page.evaluate( () => document.querySelector( '[contenteditable]' ).focus() );
}

/**
Expand All @@ -60,6 +61,7 @@ describe( 'Using Plugins API', () => {
// Click remove annotations button.
const addAnnotationButton = ( await page.$x( "//button[contains(text(), 'Remove annotations')]" ) )[ 0 ];
await addAnnotationButton.click();
await page.evaluate( () => document.querySelector( '[contenteditable]' ).focus() );
}

/**
Expand Down