Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalizing 'Manager' because Block Manager is a proper noun #19375

Merged
merged 2 commits into from
Jan 1, 2020
Merged

Capitalizing 'Manager' because Block Manager is a proper noun #19375

merged 2 commits into from
Jan 1, 2020

Conversation

mapk
Copy link
Contributor

@mapk mapk commented Dec 31, 2019

Description

Similarly to "Block Editor", the "Block Manager" is a proper noun and should be capitalized.

How has this been tested?

Tested locally.

Screenshots

Screen Shot 2019-12-31 at 11 32 23 AM

Types of changes

Non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mapk mapk added General Interface Parts of the UI which don't fall neatly under other labels. [Type] Copy Issues or PRs that need copy editing assistance labels Dec 31, 2019
@mapk mapk requested a review from talldan as a code owner December 31, 2019 19:33
@mapk mapk self-assigned this Dec 31, 2019
@mapk mapk requested review from ajitbohra, nerrad and ntwb as code owners January 1, 2020 15:57
mkaz
mkaz approved these changes Jan 1, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 👍

Note, I needed to update the e2e-test that used the label, you can see my commit for an example on how.

@mkaz mkaz merged commit 504385a into master Jan 1, 2020
@mkaz mkaz deleted the update/block-manager-title branch January 1, 2020 16:25
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@MaxMood96 MaxMood96 mentioned this pull request Nov 14, 2023
Open
@naiba4 naiba4 mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees

@mapk mapk

Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mapk @mkaz @youknowriad