Fixed dates alignments in the picker #19294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdel-h
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
jorgefilipecosta
approved these changes
Dec 23, 2019
jorgefilipecosta
force-pushed
the
update/date-picker-dates-alignement-with-days
branch
2 times, most recently
from
1bb32c9 to
b63e7c2
Compare
|
Seems like the unit test are failing because of React warnings @jorgefilipecosta on other related components |
By removing a negative margin, that probably was used to fix an issue but it's no longer needed after another recent change was made I also added a basic storybook for the component.
jorgefilipecosta
force-pushed
the
update/date-picker-dates-alignement-with-days
branch
from
b63e7c2 to
6e3ba5d
Compare
It seems better to merge the fix without the story for now. I think the problem was in a component from an external library. |
This was referenced Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix to #19228
By removing a negative margin, that probably was used to fix an issue but it's no longer needed after another recent change was made
I also added a basic storybook for the component.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: