Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move popovers and modals to the right position in the dom #18775

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Move popovers and modals to the right position in the dom #18775

merged 1 commit into from
Nov 29, 2019

Conversation

youknowriad
Copy link
Contributor

This PR restores the previous position for modals and popovers in the DOM. (before #18044)

It also ensures they are wrapped in FocusReturnProvider that way withFocusReturn should work properly there.

@youknowriad youknowriad requested a review from talldan as a code owner November 27, 2019 10:50
@youknowriad youknowriad self-assigned this Nov 27, 2019
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Nov 27, 2019
gziolo
gziolo approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have it configured this way 👍

@youknowriad youknowriad merged commit be34e5b into master Nov 29, 2019
@youknowriad youknowriad deleted the fix/move-popover-modal-dom branch November 29, 2019 10:59
@noisysocks noisysocks mentioned this pull request Nov 29, 2019
Merged
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @gziolo