-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tiny PR] Add updated README files during precommit #18657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and yes thank you that was annoying :) especially when you are not used to a stack that automagically does so many things.
This s a very dangerous change IMO, I often have changes locally that I don't want to commit. I'd prefer reverting this personally. |
@youknowriad Oh, I thought it would only add the readme changes as the rest would be stashed. Let me follow up with a PR. |
I just came across this, since I'm in the same situation as described by @youknowriad and am unable to make a partial commit of files 😬 |
@aduth Ok, sorry, I'll work on a fix right away. I thought I saw the unstated changed stashed but apparently they are not. |
No rush. I managed to get around it by temporarily reverting the changes from this branch. More of a "+1" if anything, though I suppose I could have just as well used reactions for that. Sorry to pile on! |
Created a PR to revert the change. |
Description
Currently,
README.md
files are updated duringprecommit
, but the changes are not added. This has been annoying me for a while. Only later on you realise that there are unstaged changes created by./bin/update-readmes.js
and then you need to commit them separately.Here I've added
git add .
afternode ./bin/update-readmes.js
. Note that this doesn't add any other unstaged changes as they are stashed.How has this been tested?
Update some documentation that would be added to a
README.md
file. Commit the change. Ensure that the automatedREADME.md
change is part of the commit.Screenshots
Types of changes
Checklist: