Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project management automation: Fix 'add first time contributor label' #17156

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Project management automation: Fix 'add first time contributor label' #17156

merged 1 commit into from
Aug 23, 2019

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented Aug 23, 2019 •
edited
Loading

Octokit returns the search result count as data.total_count, not total_count.

I confirmed this in my local Node REPL:

$ node
> let { GitHub } = require( '@actions/github' )
> let octokit = new GitHub( 'INSERT_PERSONAL_ACCESS_TOKEN_HERE' )
> octokit.search.commits( { q: 'repo:WordPress/gutenberg+author:geriux' } ).then( ( result ) => console.log( result ) )

@noisysocks
Project management automation: Fix 'add first time contributor label'
bee9f58 
GitHub returns the search result count as `data.total_count`, not
`total_count`.
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg labels Aug 23, 2019
@noisysocks noisysocks requested a review from talldan August 23, 2019 02:23
@talldan talldan merged commit ce46a4f into master Aug 23, 2019
@talldan talldan deleted the fix/add-first-time-contributor-label branch August 23, 2019 03:08
donmhico pushed a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
@noisysocks @donmhico
Project management automation: Fix 'add first time contributor label' (…
5d21cd0 
…WordPress#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@noisysocks @gziolo
Project management automation: Fix 'add first time contributor label' (…
c65dbb3 
…#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@noisysocks @gziolo
Project management automation: Fix 'add first time contributor label' (…
e549051 
…#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

Assignees

@noisysocks noisysocks

Labels
[Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @talldan