Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document server functions in block style variations section #16997

Conversation

jorgefilipecosta
Copy link
Member

This PR documents the server-side functions register_block_style and un register_block_style added in #16356 inside the block style variations section.

@jorgefilipecosta jorgefilipecosta self-assigned this Aug 10, 2019
@jorgefilipecosta jorgefilipecosta added [Type] Developer Documentation Documentation for developers [Feature] Block API API that allows to express the block paradigm. [Feature] Theme Style Variations Related to style variations provided by block themes labels Aug 10, 2019
Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A smattering of tweaks, but this is awesome. Thanks for documenting it 🔥

@jorgefilipecosta jorgefilipecosta force-pushed the update/expand-the-block-style-variations-documentation-to-document-server-functions branch 2 times, most recently from 4f22ecc to 144f7cf Compare August 12, 2019 09:33
@jorgefilipecosta
Copy link
Member Author

Hi @chrisvanpatten thank you a lot for the review and the suggestions. All your suggestions were applied.

@jorgefilipecosta jorgefilipecosta dismissed chrisvanpatten’s stale review August 19, 2019 13:59

Suggestions were applied

jorgefilipecosta and others added 16 commits August 19, 2019 17:21
@jorgefilipecosta jorgefilipecosta force-pushed the update/expand-the-block-style-variations-documentation-to-document-server-functions branch from 144f7cf to c371a74 Compare August 19, 2019 16:21
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this page is called "Block Filters". It's about Block Extensibility in general I think?
Anyway, separate question.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit e6c5ce0 into master Aug 20, 2019
@jorgefilipecosta jorgefilipecosta deleted the update/expand-the-block-style-variations-documentation-to-document-server-functions branch August 20, 2019 10:26
donmhico pushed a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
…s#16997)

* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Fix line break and code block closing
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Fix line break and code block closing
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <[email protected]>

* Fix line break and code block closing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants