-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Some default block appender styles are set on the editpost module #16943
Conversation
@jorgefilipecosta thanks for your work on this! I wanted to reply to your comment from the issue on this PR.
I think in context of the editor, having the smaller appender is good because the editor is meant for writing a flow of content. I believe users think of Widget Areas differently. These feel more block-related where the user adds blocks of particular content to show in a sidebar or whatever. That being said, I'd like to go with a larger custom appender. The same we use in the Columns block would be fantastic. |
@@ -41,6 +52,13 @@ | |||
} | |||
} | |||
|
|||
// Ensure that the height of the first appender, and the one between blocks, is the same as text. | |||
.block-editor-block-list__block[data-type="core/paragraph"] p, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this style belong here or in the paragraph block instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so, I moved the styles to the paragraph block 👍
860e064
to
2260e03
Compare
This PR moves styles from the edit-post module into the block editor module. These styles are required for the default block appender work as expected, and that component is part of the block editor module so these styles should be set there.
This problem is affecting the block widgets screen.
Related: #16601
How has this been tested?
I enabled the experimental widgets screen in the settings.
I went to the experimental widgets screen.
Deleted all the content in one of the block areas.
I added an image block, and I verified the insert button of the default block appender is visible, in master it is not.