Remove @wordpress/format-library dependency from edit-post #16034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Package] Edit Post
youknowriad
approved these changes
Jun 7, 2019
jorgefilipecosta
deleted the
remove/wordpress-format-library-dependency-from-edit-post
branch
|
This causes a local change to Aside: Yes, this should be captured by build tooling for artifacts, and last it was considered, it seemed to be caused by a bug with |
|
I pushed the update direct to master in 60b667e. |
aduth
added a commit
that referenced
this pull request
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The edit-post does not use the format-library package. The package is loaded by core and calls the correct mechanism to register the formats being used but the edit-post package does not directly depend on format-library.
How has this been tested?
I checked the formats still work as expected.