Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update JavaScript build and setup with wp-scripts updates #14440

Merged
merged 8 commits into from
Mar 18, 2019
Merged

Docs: Update JavaScript build and setup with wp-scripts updates #14440

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa4a18f
WIP
mkaz Mar 14, 2019
830b860
Update JS build setup with new wp-scripts commands
mkaz Mar 14, 2019
02f6909
Apply suggestions from code review
chrisvanpatten Mar 14, 2019
c3de161
Remove webpack, babel dependencies
mkaz Mar 14, 2019
9a282b7
Use output from build as entry point
oandregal Mar 15, 2019
8f5f01a
cd into the new folder before executing npm commands
oandregal Mar 15, 2019
6b95f87
Use arrow functions for effect
oandregal Mar 15, 2019
d051c6d
Update docs/designers-developers/developers/tutorials/javascript/js-b…
gziolo Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use arrow functions for effect
  • Loading branch information
@oandregal
oandregal committed Mar 15, 2019
commit 6b95f870d3485162c3902d50a65471c0347b8eec
8 changes: 2 additions & 6 deletions docs/designers-developers/developers/tutorials/javascript/js-build-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,8 @@ registerBlockType( 'myguten/test-block', {
title: 'Basic Example',
icon: 'smiley',
category: 'layout',
edit() {
return <div>Hola, mundo!</div>;
},
save() {
return <div>Hola, mundo!</div>;
},
edit: () => <div>Hola, mundo!</div>,
save: () => <div>Hola, mundo!</div>,
} );
```

Expand Down