-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the npm packages release process #14136
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Link to the WordPress release cycle documentation.
Co-Authored-By: youknowriad <[email protected]>
- Loading branch information
commit 2b792bc29dd1a3c86fe98d97fd509a87d2a8dccc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the https://github.com/wordpress/wordpress-develop repo uses
x.y
for branches, andx.y.z
for tags, this includes the major releases tagged asx.y.z
, for example5.1.0
• https://github.com/WordPress/wordpress-develop/branches
• https://github.com/WordPress/wordpress-develop/tags
I suggest rather than
wp/5.2
thatwp/5.2.0
is used so that Gutenberg uses a consistent 3 digit nomenclature?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Gutenberg should use the same thing
wp/5.2
for the branch andx.y.z
for tags. thewp/5.2
will serve for all5.2.1
,5.2.2
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When WordPress releases a major release it is both branched and tagged, so a
5.0
branch is created, and a5.1.0
tag is created:•
5.0
branch https://github.com/WordPress/wordpress-develop/tree/5.1•
5.1.0
tag https://github.com/WordPress/wordpress-develop/tree/5.1.0All
package.json
files use the 3 digit nomenclature:https://github.com/WordPress/wordpress-develop/blob/5.1.0/package.json#L3:
Also, to note that the
5.0
branch has now had 4 minor releases so the 5.0 branchpackage.json
file is now5.0.4
:https://github.com/WordPress/wordpress-develop/blob/5.0/package.json#L3:
If as you suggest, Gutenberg only use
wp/5.2
for all5.2.x
releases I think that would work and be less work to maintain....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags are automatically created by Lerna when we publish the packages. we can probably also tag
wp-5.2.1
ourselves, but the issue is that at the time of the npm release, we don't know yet if it's the final npm release that will be merged in this WP version and if we won't need more. So maybe just using the branch and the lerna tags is enough.