Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the npm packages release process #14136

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Update the npm packages release process #14136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d74b326
Update the npm packages release process
youknowriad Feb 27, 2019
2b792bc
Link to the WordPress release cycle documentation.
nosolosw Feb 27, 2019
2d83385
Update docs/contributors/release.md
gziolo Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Link to the WordPress release cycle documentation. 
Co-Authored-By: youknowriad <[email protected]>
  • Loading branch information
@nosolosw @youknowriad
nosolosw and youknowriad authored Feb 27, 2019
commit 2b792bc29dd1a3c86fe98d97fd509a87d2a8dccc
2 changes: 1 addition & 1 deletion docs/contributors/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ If you don't have access to [make.wordpress.org/core](https://make.wordpress.org

## Packages Releases and WordPress Core Updates

The Gutenberg repository mirrors the WordPress SVN repository in terms of branching for each SVN branch, a corresponding Gutenberg `wp/*` branch is created:
The Gutenberg repository mirrors the [WordPress SVN repository](https://make.wordpress.org/core/handbook/about/release-cycle/) in terms of branching for each SVN branch, a corresponding Gutenberg `wp/*` branch is created:

- The `wp/trunk` branch contains all the packages that are published and used in the `trunk` branch of WordPress.
- A Gutenberg branch targetting a specific WordPress release and its minors is created (example `wp/5.2`) based on the `wp/trunk` Gutenberg branch when the WordPress `trunk` branch is marked as "feature-freezed". (This usually happens when the first `beta` of the next WordPress major version is released).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the https://github.com/wordpress/wordpress-develop repo uses x.y for branches, and x.y.z for tags, this includes the major releases tagged as x.y.z, for example 5.1.0

• https://github.com/WordPress/wordpress-develop/branches
• https://github.com/WordPress/wordpress-develop/tags

I suggest rather than wp/5.2 that wp/5.2.0 is used so that Gutenberg uses a consistent 3 digit nomenclature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Gutenberg should use the same thing wp/5.2 for the branch and x.y.z for tags. the wp/5.2 will serve for all 5.2.1, 5.2.2...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When WordPress releases a major release it is both branched and tagged, so a 5.0 branch is created, and a 5.1.0 tag is created:

• 5.0 branch https://github.com/WordPress/wordpress-develop/tree/5.1
• 5.1.0 tag https://github.com/WordPress/wordpress-develop/tree/5.1.0

All package.json files use the 3 digit nomenclature:

https://github.com/WordPress/wordpress-develop/blob/5.1.0/package.json#L3:

"version": "5.1.0",

Also, to note that the 5.0 branch has now had 4 minor releases so the 5.0 branch package.json file is now 5.0.4:
https://github.com/WordPress/wordpress-develop/blob/5.0/package.json#L3:

"version": "5.1.0",

If as you suggest, Gutenberg only use wp/5.2 for all 5.2.x releases I think that would work and be less work to maintain....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are automatically created by Lerna when we publish the packages. we can probably also tag wp-5.2.1 ourselves, but the issue is that at the time of the npm release, we don't know yet if it's the final npm release that will be merged in this WP version and if we won't need more. So maybe just using the branch and the lerna tags is enough.

Expand Down