Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach build and start commands to use Webpack default if none is provided #13877

Merged
merged 15 commits into from
Mar 12, 2019
Merged

Teach build and start commands to use Webpack default if none is provided #13877

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e9ffeee
Use a default webpack config if none is provided
oandregal Feb 14, 2019
1c714b0
Extract webpack utils from build command
oandregal Feb 14, 2019
9a78fcb
Update start command
oandregal Feb 14, 2019
f556fb3
Add docs
oandregal Feb 21, 2019
f6469a0
Add Webpack documentation
oandregal Feb 21, 2019
91f9829
Add example of how to overwrite the default plugins
oandregal Feb 22, 2019
343410d
Do not export hasWebpackConfig
oandregal Feb 27, 2019
0c9362b
Always pass webpack CLI args to command
oandregal Feb 27, 2019
b6b4524
Update README
oandregal Feb 27, 2019
374f662
Remove section on extending the default webpack config file
oandregal Feb 27, 2019
3d34702
Simplify array passing
gziolo Mar 11, 2019
c1fa8c7
Simplify pushing to array
gziolo Mar 11, 2019
196ec3e
Fix externals docs
oandregal Mar 11, 2019
d81c7ed
Use webpack instead of Webpack
oandregal Mar 11, 2019
6da9e92
Add Changelog entry
oandregal Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always pass webpack CLI args to command
  • Loading branch information
@oandregal
oandregal committed Mar 11, 2019
commit 0c9362b821d87a573291aaf1cafa148c30d2e873
6 changes: 2 additions & 4 deletions packages/scripts/utils/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ const hasWebpackConfig = () => hasCliArg( '--config' ) ||
hasProjectFile( 'webpack.config.babel.js' );

const getWebpackArgs = ( additionalArgs = [] ) => {
const webpackArgs = [];
if ( hasWebpackConfig() ) {
webpackArgs.push( ...getCliArgs() );
} else {
const webpackArgs = [ ...getCliArgs() ];
if ( ! hasWebpackConfig() ) {
webpackArgs.push( ...[ '--config', fromConfigRoot( 'webpack.config.js' ) ] );
}
webpackArgs.push( ...additionalArgs );
Expand Down