Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up: rm unused variable fallbacks in RichText #10688

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 17, 2018

Description

Addresses #5769 (comment)

Should have no effect whatsoever.

How has this been tested?

Try operating a RichText component, try switching to and from mobile view with the browser's Response Mode, make sure no errors arise.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@mcsf mcsf added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 17, 2018
@mcsf mcsf requested a review from aduth October 17, 2018 15:36
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@aduth aduth added this to the 4.2 milestone Oct 23, 2018
@aduth aduth merged commit 77fab02 into master Oct 23, 2018
@aduth aduth deleted the fix/unused-fallback-values branch October 23, 2018 14:29
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants