-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EditorConfig: Relax 2 space indentation rule to only the `package.json #1067
Conversation
…n` and `*.yml` files. This is a partial revert of 7c9cfe4, originally it was added so that it was in sync with WordPress' `.editorconfig`, rather WordPress should follow suit of how it's done here.
Upstream core ticket https://core.trac.wordpress.org/ticket/40946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we restore tabs to composer.json
here as well?
Do .yml
files need two-spaces generally, or is it just Travis being picky?
The |
🍿 🍿 🍿 |
I added commit 09b849b that switches |
This is a partial revert of 7c9cfe4, originally it was added so that it was in sync with WordPress'
.editorconfig
, rather WordPress should follow suit of how it's done here.Follow up to #1029 / #1022