Fix publish buttons with long text #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Oct 11, 2018
| justify-content: center; | ||
| padding: 3px 10px 4px; | ||
| line-height: 20px; |
There was a problem hiding this comment.
Shouldn't line-height's be unitless?
mtias
added
the
Internationalization (i18n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the post-publish buttons use longer text strings, they run off the screen. This should be solved by the changes planned in #9398, but since that's been a bit stalled this is a quick patch in the meantime.
Before:
After:
It's not 100% ideal but it should accommodate any range of text strings for these buttons.
The CSS changes introduced here are specific only to these two buttons, rather than being scoped more widely across other button components. This seems a sensible approach here since there's already quite a bit of CSS that's scoped specifically to these instances of the buttons, and since this panel is subject to change at some point in the potentially maybe near-ish future-ish.
Checklist: