-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in separators to block sidebar like document sidebar #7686
Comments
(I see now this relates to #7063, which I also commented on… d'oh. Leaving this open for now as it's a little more specific, and I'm also going to work on a PR.) |
@chrisvanpatten I hope it was ok but I adjusted the title to make sure it was I think what you wanted? I agree that both should reflect the same style. I don't see it as a design decisions that means we shouldn't implement. @ajitbohra just a little note on good first issue, totally this could be but let's make sure we get design decisions in first to ensure those coming into that first issue are able to just work on it. Also I think this maybe is Chrome but those labels are a little confusing in this case. |
@karmatosed thanks! 4th of July prep got me sidetracked but I’ll work up a PR ASAP. |
@chrisvanpatten awesome thanks and happy 4th of July for yesterday! |
Finally pushed up a commit for this! 💃 |
Currently, accordion panels in the block inspector are unique from the document inspector, because they don't have separators.
This gets especially confusing when you have blocks with many options, because the panels can blend together, for example in one of our custom blocks:
While I suspect this was originally an intentional choice (and it works well enough with core blocks, which are relatively option-light), I think greater consistency between Document and Block Inspectors could be beneficial, and improve 'scanability'.
The text was updated successfully, but these errors were encountered: