Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BorderBoxControl clear button not always visible #69065

Closed
3 of 6 tasks
shimotmk opened this issue Feb 5, 2025 · 1 comment · Fixed by #69066
Closed
3 of 6 tasks

BorderBoxControl clear button not always visible #69065

shimotmk opened this issue Feb 5, 2025 · 1 comment · Fixed by #69066
Assignees
@shimotmk
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@shimotmk
Copy link
Contributor

shimotmk commented Feb 5, 2025

Description

The BorderBoxControl will not display the clear button unless you set the color and style.
Also, when the clear button appears, the position of the popover changes, creating a small amount of stress.

Solution
Make the clear button always visible, just like the color component.

related
#63310
#68454

Step-by-step reproduction instructions

  1. Go to post or page
  2. Set borders for paragraph blocks, etc.
  3. You can see that the clear button will not be displayed unless you set the color or line.

Screenshots, screen recording, code snippet

before.mp4

After

Image

Environment info

  • Gutenberg 20.2.0

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@shimotmk shimotmk added the [Type] Bug An existing feature does not function as intended label Feb 5, 2025
shimotmk added a commit to shimotmk/gutenberg that referenced this issue Feb 5, 2025
@shimotmk
fix WordPress#69065
77e408b
@shimotmk shimotmk mentioned this issue Feb 5, 2025
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 5, 2025
@yogeshbhutkar
Copy link
Contributor

This issue has also been reported on Trac.

@t-hamano t-hamano added the [Package] Components /packages/components label Feb 11, 2025
@ciampo ciampo closed this as completed in 388d664 Feb 15, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this issue Feb 24, 2025
@shimotmk @ciampo
@Mamaduka @Kallyan01
BorderControl: always show Reset button (WordPress#69066)
023d202 
* fix WordPress#69065

* remove showClearButton props

* test

* changelog

* changelog

* changelog

* clear → reset

* clear → reset

* fix

---

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shimotmk shimotmk

Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BorderControl: always show Reset button shimotmk/gutenberg
3 participants
@shimotmk @t-hamano @yogeshbhutkar