Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP include and related statements are not functions #4252

Closed
schlessera opened this issue Jan 3, 2018 · 0 comments
Closed

PHP include and related statements are not functions #4252

schlessera opened this issue Jan 3, 2018 · 0 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@schlessera
Copy link
Member

Issue Overview

The PHP include and related statements are not functions. They don't require parentheses, and adding them nevertheless just creates unnecessary extra processing.

Expected Behavior

Include statements should be used without parentheses:

include 'folder/some_file.php';

Current Behavior

The include statements use superfluous parentheses:

include( 'folder/some_file.php' );

Possible Solution

Parentheses should be removed on include statements.

@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. labels Jan 3, 2018
schlessera added a commit to schlessera/gutenberg that referenced this issue Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants