Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core/edit-post initialize action to a data component #15403

Closed
nerrad opened this issue May 2, 2019 · 1 comment
Closed

Refactor core/edit-post initialize action to a data component #15403

nerrad opened this issue May 2, 2019 · 1 comment
Labels
[Package] Edit Post /packages/edit-post [Type] Enhancement A suggestion for improvement.

Comments

@nerrad
Copy link
Contributor

nerrad commented May 2, 2019

Surfaced as a part of the discussion that happened in #14740 comment:

My initial reaction is: While the subscribe control is the most faithful adaptation of the current implementation, is it something where we might want to lean instead on other patterns around subscribed component behaviors, optionally as data-only components (example)?

At a minimum there should be some consideration of exposing how to unsubscribe the listeners.

@nerrad
Copy link
Contributor Author

nerrad commented May 6, 2019

Closing this in favor of the open pull.

@nerrad nerrad closed this as completed May 6, 2019
nerrad added a commit that referenced this issue Jun 25, 2019
…nstableInitialize action. (fixes #15403) (#15444)

Create EditorInitializer component and implement for various things to initialize as the editor is loaded. This replaces the `__unstableInitialize` refactor done in #14740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Post /packages/edit-post [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant