Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select separator block #12080

Closed
xy0 opened this issue Nov 19, 2018 · 15 comments
Closed

Cannot select separator block #12080

xy0 opened this issue Nov 19, 2018 · 15 comments
Labels
[Block] Separator Affects the Separator Block [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Milestone

Comments

@xy0
Copy link

xy0 commented Nov 19, 2018

I'm creating this because I believe this isn't theme territory. You can click on different types of blocks and apply "Additional CSS Classes". Prior to the last update, this worked on Separator blocks. Now, clicking on the Separator block does not change the right-hand details panel at all.

Current Firefox, win10

@designsimply designsimply added [Feature] Blocks Overall functionality of blocks Needs Testing Needs further testing to be confirmed. labels Nov 19, 2018
@xy0
Copy link
Author

xy0 commented Nov 19, 2018

Update

I am able to select the Separator options by hovering over the separator then clicking on the drag-able handle that appears to the left of the separator. However, the classes I put into the Advanced -> Additional CSS classes do not appear to be added to the element.

@designsimply
Copy link
Member

designsimply commented Nov 21, 2018

Thanks for the report and the update! It sounds like there are two separate issues and I can confirm the first one but not the second:

  1. Cannot access separator block settings (toolbar & sidebar) by clicking on it.
  2. Cannot apply custom classes to separator block via the "Additional CSS Class" in the "Advanced" panel in the block settings sidebar.

I tested with WordPress 4.9.8 and Gutenberg 4.5.1 using Firefox 63.0.1 on macOS 10.13.6 and confirmed the first bug that I couldn't reach the block settings by clicking with the mouse but I was able to apply and save custom classes in the "Additional CSS Class" field. I did my test with WordPress 4.9.8 and Gutenberg 4.5.1 using Firefox 63.0.1 on macOS 10.13.6 and Firefox 63 on Windows 10.

screen shot 2019-01-16 at 7 18 21 am

Video: 2min
Seen at https://tan-otter.jurassic.ninja/wp-admin/post.php?post=72&action=edit running WordPress 4.9.8 and Gutenberg 4.5.1 using Firefox 63 Windows 10.

@xy0 can you have a look at the video and let me know if my testing steps match with what you did? Did you save the post after adding an additional css class or notice whether autosave happened after you did that? Can you also make a note of your plugin version or your WP version if you're using one of the WP 5.0 beta versions?

Temporary workaround for accessing the block settings: tap into an adjacent block and press the up or down arrow keys to navigate to and select the separator block.

Note: not being able to click on a block to access block settings also came up for video blocks in #12080.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. and removed Needs Testing Needs further testing to be confirmed. labels Nov 21, 2018
@designsimply designsimply changed the title Unable to apply custom classes to Separator block Cannot access separator block settings by clicking Nov 21, 2018
@designsimply designsimply added the [Status] Needs More Info Follow-up required in order to be actionable. label Nov 21, 2018
@mcsf mcsf added this to the WordPress 5.0.x Follow Ups milestone Nov 22, 2018
@mcsf
Copy link
Contributor

mcsf commented Nov 22, 2018

  1. Cannot apply custom classes to separator block via the "Additional CSS Class" in the "Advanced" panel in the block settings sidebar.

If this gets confirmed, it should be opened in a separate issue.

For 1., i.e. not being able to click on the separator, I'm putting this in 5.0.x for investigation.

@designsimply designsimply removed the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 5, 2018
@designsimply
Copy link
Member

Removed the [Status] Needs More Info label and would like to ask for a separate issue to be filed if the problem where you could not save and "Additional CSS Class" in the "Advanced" panel in the block settings sidebar comes up again.

Re-tested with WordPress 4.9.8 and Gutenberg 4.6.1 master @ 874321773 and confirmed that I cannot click on a separator block to access it's setting after it is added and focus is changed to elsewhere.

@designsimply
Copy link
Member

Related: #11885, #12577

@troe
Copy link

troe commented Dec 7, 2018

The same problem, updated on WordPress 5.0, the separator stopped working, I can get to the separator settings only through "Navigation in blocks", in general, the separator settings work.

I am able to select the Separator options by hovering over the separator then clicking on the drag-able handle that appears to the left of the separator

This method also works.

@xy0
Copy link
Author

xy0 commented Dec 14, 2018

@designsimply Your video perfectly describes the behavior that I see as well. The 2nd issue of not being able to apply classes, this is solved by using designsimply's workaround or by clicking on the scroll handle (on the right-side of the separator). Therefore no new issue needs to be created as it is derivative of the primary issue. I guess I was mistaken when not seeing them update.

@emfluenceindia
Copy link

emfluenceindia commented Dec 17, 2018

Can this be a possible solution? (wp-includes/css/dist/block-library/theme.css)

.wp-block-separator {
  ...
  padding: 10px;
}

/* Allows users to understand the clickable area (height) since it is small */
.wp-block-separator:hover {
    cursor: pointer;
}

This allows me to click and select the <hr /> block.

Here is a screencast
https://drive.google.com/file/d/1V8hMsHCJKANl6T3zVOoyNsq6EEor0Kuw/view

@sulli-a
Copy link

sulli-a commented Dec 18, 2018

Hello,

It's better to use rem unit like others styles in Gutenberg, I propose :

.wp-block-separator { ... padding: 0.65rem 0; }

@xy0
Copy link
Author

xy0 commented Dec 18, 2018

So that the extra padding is only visible in the editor I have

.block-editor .wp-block-separator { 
  padding: 0.65rem 0;
  background: #f3f3f3;
}

@swissspidy
Copy link
Member

Another report for this: https://core.trac.wordpress.org/ticket/46008

@bobbingwide
Copy link
Contributor

You might want to take this into account too. I was working on separator styling and duplicated the separator block. Having mistakenly moved the first block above another ( pullquote in this instance ) I got the situation where there were two active block movement blocks. And the up arrow for the lower block was above the down arrow for the Separator block.
image

@afercia
Copy link
Contributor

afercia commented Mar 10, 2019

Worth noting that not being able to select a separator block makes also very difficult to remove the block. Given the block is not selected, pressing Backspace doesn't do anything in most of the browsers. With Firefox, it triggers the default action: go back one page, which is completely unexpected.

@afercia
Copy link
Contributor

afercia commented Mar 10, 2019

I'd suggest to change this issue title to: "Cannot select separator block".

@xy0 xy0 changed the title Cannot access separator block settings by clicking Cannot select separator block Mar 20, 2019
@gziolo gziolo added the [Type] Regression Related to a regression in the latest release label Apr 10, 2019
@gziolo
Copy link
Member

gziolo commented Apr 10, 2019

Closed with #14854.

@gziolo gziolo closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Separator Affects the Separator Block [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.