Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Performance Tests Workflow: Polish Bash script (#32284)
* Workflows: Performance: Avoid non-POSIX `grep -P` `grep -P` is a GNU extension to use PCRE regular expressions. While it is commonly available on GNU/Linux systems, it is not POSIX and cannot be guaranteed to exist. By replacing it with POSIX-compliant AWK, this workflow is easier to test locally on different systems, including all BSD-derived ones. * Workflows: Performance: Use safer or more modern Bash * Prefer `$(( ... ))` over antiquated `expr` * Use double quotes to prevent globbing and word splitting * Condense `read` options... just because As a general note, Shellcheck [1] is an excellent tool for linting and validating shell scripts. [1]: https://www.shellcheck.net/ * Workflows: Performance: Explicitly require Bash shell The `run` block for the "Compare performance with current WordPress Core and previous Gutenberg versions" job relies on a series of Bashisms, so we should make that an explicit requirement.
- Loading branch information