Skip to content

Commit

Permalink
refactor: Remove Hermes engine status log
Browse files Browse the repository at this point in the history
While informative, this un-filterable log increases the amount of noise
in the server log, which can make it difficult to debug errors,
warnings, or intentionally logged values. Additionally, the Hermes
engine is now globally enabled for both iOS and Android.
  • Loading branch information
dcalhoun committed Aug 1, 2023
1 parent 286fbbe commit 63383b3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions packages/react-native-editor/src/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ const gutenbergSetup = () => {

setupApiFetch();

const isHermes = () => global.HermesInternal !== null;
// eslint-disable-next-line no-console
console.log( 'Hermes is: ' + isHermes() );

setupInitHooks();
};

Expand Down
1 change: 0 additions & 1 deletion packages/react-native-editor/src/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ describe( 'Register Gutenberg', () => {
registerCoreBlocksCallOrder
);
expect( callbackCallOrder ).toBeLessThan( onRenderEditorCallOrder );
expect( console ).toHaveLoggedWith( 'Hermes is: true' );

initializeEditorMock.mockRestore();
} );
Expand Down

0 comments on commit 63383b3

Please sign in to comment.