remove store subscription per action

WordPress · Jun 24, 2024 · 471e144 · 471e144
1 parent eda037c
commit 471e144
Showing 1 changed file with 31 additions and 31 deletions.
diff --git a/packages/editor/src/components/post-actions/actions.js b/packages/editor/src/components/post-actions/actions.js
@@ -307,18 +307,8 @@ const trashPostAction = {
 	},
 };
 
-function useCanUserEligibilityCheckPostType( postType, capability, action ) {
+function useCanUserEligibilityCheckPostType( capability, resource, action ) {
 	const registry = useRegistry();
-	const { resource, cachedCanUserResolvers } = useSelect(
-		( select ) => {
-			const { getPostType, getCachedResolvers } = select( coreStore );
-			return {
-				resource: getPostType( postType )?.rest_base || '',
-				cachedCanUserResolvers: getCachedResolvers().canUser,
-			};
-		},
-		[ postType ]
-	);
 	return useMemo(
 		() => ( {
 			...action,
@@ -331,17 +321,14 @@ function useCanUserEligibilityCheckPostType( postType, capability, action ) {
 				);
 			},
 		} ),
-		// We are making this use memo depend on cachedCanUserResolvers as a way to make the component using this hook re-render
-		// when user capabilities are resolved. This makes sure the isEligible function is re-evaluated.
-		// eslint-disable-next-line react-hooks/exhaustive-deps
-		[ action, registry, capability, resource, cachedCanUserResolvers ]
+		[ action, registry, capability, resource ]
 	);
 }
 
-function useTrashPostAction( postType ) {
+function useTrashPostAction( resource ) {
 	return useCanUserEligibilityCheckPostType(
-		postType,
 		'delete',
+		resource,
 		trashPostAction
 	);
 }
@@ -436,10 +423,10 @@ const permanentlyDeletePostAction = {
 	},
 };
 
-function usePermanentlyDeletePostAction( postType ) {
+function usePermanentlyDeletePostAction( resource ) {
 	return useCanUserEligibilityCheckPostType(
-		postType,
 		'delete',
+		resource,
 		permanentlyDeletePostAction
 	);
 }
@@ -551,10 +538,10 @@ const restorePostAction = {
 	},
 };
 
-function useRestorePostAction( postType ) {
+function useRestorePostAction( resource ) {
 	return useCanUserEligibilityCheckPostType(
-		postType,
 		'update',
+		resource,
 		restorePostAction
 	);
 }
@@ -718,10 +705,10 @@ const renamePostAction = {
 	},
 };
 
-function useRenamePostAction( postType ) {
+function useRenamePostAction( resource ) {
 	return useCanUserEligibilityCheckPostType(
-		postType,
 		'update',
+		resource,
 		renamePostAction
 	);
 }
@@ -1070,27 +1057,36 @@ export const duplicateTemplatePartAction = {
 };
 
 export function usePostActions( { postType, onActionPerformed, context } ) {
-	const { defaultActions, postTypeObject, userCanCreatePostType } = useSelect(
+	const {
+		defaultActions,
+		postTypeObject,
+		userCanCreatePostType,
+		resource,
+		cachedCanUserResolvers,
+	} = useSelect(
 		( select ) => {
-			const { getPostType, canUser } = select( coreStore );
+			const { getPostType, canUser, getCachedResolvers } =
+				select( coreStore );
 			const { getEntityActions } = unlock( select( editorStore ) );
 			const _postTypeObject = getPostType( postType );
-			const resource = _postTypeObject?.rest_base || '';
+			const _resource = _postTypeObject?.rest_base || '';
 			return {
 				postTypeObject: _postTypeObject,
 				defaultActions: getEntityActions( 'postType', postType ),
-				userCanCreatePostType: canUser( 'create', resource ),
+				userCanCreatePostType: canUser( 'create', _resource ),
+				resource: _resource,
+				cachedCanUserResolvers: getCachedResolvers()?.canUser,
 			};
 		},
 		[ postType ]
 	);
 
 	const duplicatePostAction = useDuplicatePostAction( postType );
-	const trashPostActionForPostType = useTrashPostAction( postType );
+	const trashPostActionForPostType = useTrashPostAction( resource );
 	const permanentlyDeletePostActionForPostType =
-		usePermanentlyDeletePostAction( postType );
-	const renamePostActionForPostType = useRenamePostAction( postType );
-	const restorePostActionForPostType = useRestorePostAction( postType );
+		usePermanentlyDeletePostAction( resource );
+	const renamePostActionForPostType = useRenamePostAction( resource );
+	const restorePostActionForPostType = useRestorePostAction( resource );
 	const isTemplateOrTemplatePart = [
 		TEMPLATE_POST_TYPE,
 		TEMPLATE_PART_POST_TYPE,
@@ -1183,6 +1179,9 @@ export function usePostActions( { postType, onActionPerformed, context } ) {
 		}
 
 		return actions;
+		// We are making this use memo depend on cachedCanUserResolvers as a way to make the component using this hook re-render
+		// when user capabilities are resolved. This makes sure the isEligible functions of actions dependent on capabilities are re-evaluated.
+		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, [
 		defaultActions,
 		userCanCreatePostType,
@@ -1199,5 +1198,6 @@ export function usePostActions( { postType, onActionPerformed, context } ) {
 		supportsRevisions,
 		supportsTitle,
 		context,
+		cachedCanUserResolvers,
 	] );
 }