Skip to content

Commit

Permalink
Try old hover design
Browse files Browse the repository at this point in the history
There has been discussion on the heaviness of the blocks. Initially this led us to having only the left border on hover. We added a full outline so as to better portray that a paragraph is a block.

However multi selection across blocks works well. If we can get it to work as well with keyboard shortcuts (and show list and quote options in a toolbar), aside from this addressing #539, it seems like there's less of a need for the block outlines to look so heavy.
  • Loading branch information
jasmussen committed Aug 2, 2017
1 parent fef2904 commit 3474036
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions editor/modes/visual-editor/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
margin-bottom: 5px;
max-width: $visual-editor-max-width + ( 2 * $block-mover-padding-visible );
position: relative;

padding: $block-padding;
transition: 0.2s border;

@include break-small {
// The block mover needs to stay inside the block to allow clicks when hovering the block
Expand All @@ -42,8 +42,8 @@
z-index: z-index( '.editor-visual-editor__block:before' );
content: '';
position: absolute;
outline: 1px solid transparent;
transition: 0.2s outline;
border: 2px solid transparent;
transition: 0.2s border;
top: 0;
bottom: 0;

Expand Down Expand Up @@ -74,13 +74,11 @@
}

&.is-hovered:before {
outline: 1px solid $light-gray-500;
transition: 0.2s outline;
border-left: 2px solid $light-gray-500;
}

&.is-selected:before {
outline: 2px solid $light-gray-500;
transition: 0.2s outline;
border: 2px solid $light-gray-500;
}

&.is-showing-mobile-controls {
Expand Down

0 comments on commit 3474036

Please sign in to comment.