Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polyfill dependencies #155

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Remove polyfill dependencies #155

merged 1 commit into from
Oct 8, 2021

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 6, 2021

Description

With the merging of WordPress/gutenberg#35038
the wp-polyfill is no longer a required dependency for the blocks.

With the merging of WordPress/gutenberg#35038
the wp-polyfill is no longer a required dependency for the blocks.
@ryanwelcher
Copy link
Contributor

Looks great! The only thing worth mentioning is that the blocks with a build process will most likely have wp-polyfill added back in via this setting in the @wordpress/scripts - https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/config/webpack.config.js#L250

@mkaz
Copy link
Member Author

mkaz commented Oct 6, 2021

So, I think we can adjust this by adding WP_NO_EXTERNALS=true in front of the wp-script commands.

What do you think, should we do this by default for create-block script?

@mkaz
Copy link
Member Author

mkaz commented Oct 6, 2021

Actually, I'm wrong about the WP_NO_EXTERNALS that would prevent the assets from being created at all.

I created an issue on Gutenberg repo to discuss: WordPress/gutenberg#35410

@mkaz
Copy link
Member Author

mkaz commented Oct 8, 2021

With the merge of WordPress/gutenberg#35436 we can remove here.

@mkaz mkaz merged commit 11238c4 into trunk Oct 8, 2021
@mkaz mkaz deleted the remove/polyfills branch October 8, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants