Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Remove components and everything related to them #217

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

DAreRodz
Copy link
Collaborator

This PR gets rid of custom web components (e.g., <wp-context>, <wp-show>, etc.) as an alternative/complement to directives.

@DAreRodz DAreRodz requested a review from luisherranz April 18, 2023 10:22
@DAreRodz DAreRodz changed the base branch from main-wp-directives-plugin to refactoring-for-gutenberg April 18, 2023 10:31
@DAreRodz DAreRodz force-pushed the remove-components branch from 6ff5c07 to f65dde3 Compare April 18, 2023 17:05
@DAreRodz
Copy link
Collaborator Author

@luisherranz, I guess this PR should be merged in main-wp-directives-plugin, am I right? 🤔

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one can go to the main branch.

LGTM, David. Thanks!!

@luisherranz luisherranz changed the base branch from refactoring-for-gutenberg to main-wp-directives-plugin April 20, 2023 14:51
@DAreRodz DAreRodz force-pushed the remove-components branch from f65dde3 to 2c1a70a Compare April 21, 2023 08:22
@luisherranz luisherranz merged commit 855c1e5 into main-wp-directives-plugin Apr 21, 2023
@luisherranz luisherranz deleted the remove-components branch April 21, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants