Skip to content

Commit

Permalink
Update trustedScoringSignalsUrl to trustedScoringSignalsURL
Browse files Browse the repository at this point in the history
Bug: 1432707
Change-Id: I7fab72109d2117a2c53ca33d7c4ff695f3237216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4799228
Reviewed-by: Caleb Raitto <[email protected]>
Commit-Queue: Tianyang Xu <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1189203}
  • Loading branch information
Tianyang Xu authored and chromium-wpt-export-bot committed Aug 28, 2023
1 parent c042d52 commit 848ef94
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions fledge/tentative/auction-config.https.sub.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,15 @@ makeTest({
});

makeTest({
name: 'trustedScoringSignalsUrl is invalid',
name: 'trustedScoringSignalsURL is invalid',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: { trustedScoringSignalsUrl: "https://foo:99999999999" },
auctionConfigOverrides: { trustedScoringSignalsURL: "https://foo:99999999999" },
});

makeTest({
name: 'trustedScoringSignalsUrl is cross-origin with seller',
name: 'trustedScoringSignalsURL is cross-origin with seller',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: { trustedScoringSignalsUrl: "https://example.com" },
auctionConfigOverrides: { trustedScoringSignalsURL: "https://example.com" },
});

makeTest({
Expand Down
8 changes: 4 additions & 4 deletions fledge/tentative/trusted-scoring-signals.https.sub.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// given for TRUSTED_SCORING_SIGNALS_URL.
async function runTrustedScoringSignalsTest(test, uuid, renderURL, scoreAdCheck) {
const auctionConfigOverrides = {
trustedScoringSignalsUrl: TRUSTED_SCORING_SIGNALS_URL,
trustedScoringSignalsURL: TRUSTED_SCORING_SIGNALS_URL,
decisionLogicURL:
createDecisionScriptURL(uuid, {
scoreAd: `if (!(${scoreAdCheck})) throw "error";` })};
Expand Down Expand Up @@ -58,7 +58,7 @@ async function runTrustedScoringSignalsDataVersionTest(
sendReportTo('${createSellerReportUrl(uuid, '2-error')}')
sendReportTo('${createSellerReportUrl(uuid, '2')}')`,
}),
trustedScoringSignalsUrl: TRUSTED_SCORING_SIGNALS_URL
trustedScoringSignalsURL: TRUSTED_SCORING_SIGNALS_URL
}
await runBasicFledgeAuctionAndNavigate(test, uuid, auctionConfigOverrides);
await waitForObservedRequests(
Expand Down Expand Up @@ -87,7 +87,7 @@ promise_test(async test => {
{ uuid: uuid,
auctionConfigOverrides: { decisionLogicURL: decisionLogicScriptUrl }
});
}, 'No trustedScoringSignalsUrl.');
}, 'No trustedScoringSignalsURL.');

promise_test(async test => {
const uuid = generateUuid(test);
Expand Down Expand Up @@ -265,7 +265,7 @@ promise_test(async test => {
const renderURL2 = createRenderUrl(uuid, /*script=*/null, /*signalsParam=*/'string-value');
await joinInterestGroup(test, uuid, {ads: [{renderUrl: renderURL1}], name: '1'});
await joinInterestGroup(test, uuid, {ads: [{renderUrl: renderURL2}], name: '2'});
let auctionConfigOverrides = { trustedScoringSignalsUrl: TRUSTED_SCORING_SIGNALS_URL };
let auctionConfigOverrides = { trustedScoringSignalsURL: TRUSTED_SCORING_SIGNALS_URL };

// scoreAd() only accepts the first IG's bid, validating its trustedScoringSignals.
auctionConfigOverrides.decisionLogicURL =
Expand Down

0 comments on commit 848ef94

Please sign in to comment.