Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve documentation #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/improve documentation #85

wants to merge 2 commits into from

Conversation

PaxPax
Copy link

@PaxPax PaxPax commented Apr 17, 2021

Added details for slots, events, and disptach events; also added more events to be forwarded. I didn't want to do all of them at once, I figured it would be too large of a pr. Let me know what you think!

@Wolfr
Copy link
Owner

Wolfr commented Apr 20, 2021

Thanks the inspiration and work!

I used this as a base to work on this branch: https://github.com/Wolfr/sveltekit-jui/tree/forward-events

Not sure about forwarding a click event on the Badge or Avatar; I think it might be better to provide an interactive avatar instead (with an element) and then put the click on the element.

Same for badge, where I can imagine a badge having a tooltip, or being clickable. Then that means we need to add an interactive variant and a variant where there is an aria role of tooltip added (in case of tooltip used).

I will also need to look at the visual display of the table with forwarded events, so that's why I didn't commit it to main yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants