Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update advanced stats model #75

Merged
merged 4 commits into from
Oct 26, 2019
Merged

Conversation

WojciechZankowski
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #75 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
- Coverage     98.22%   98.21%   -0.01%     
+ Complexity     2913     2893      -20     
============================================
  Files           396      394       -2     
  Lines          8097     8065      -32     
  Branches       1202     1197       -5     
============================================
- Hits           7953     7921      -32     
  Misses          134      134              
  Partials         10       10
Impacted Files Coverage Δ Complexity Δ
.../iextrading4j/api/alternative/CryptoBookEvent.java 100% <ø> (ø) 13 <0> (ø) ⬇️
...wski/iextrading4j/api/stocks/v1/AdvancedStats.java 100% <100%> (ø) 48 <2> (+4) ⬆️
.../request/alternative/CryptoBookRequestBuilder.java 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8883357...ffd740e. Read the comment docs.

@WojciechZankowski WojciechZankowski merged commit e8f5fa1 into master Oct 26, 2019
@WojciechZankowski WojciechZankowski deleted the update-advanced-stats-model branch November 9, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants